feat(cmd/rofl): Add TDX container build support #335
+1,130
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
force-pushed
the
kostko/feature/rofl-tdx-podman
branch
2 times, most recently
from
6f0a4e1 to
9189c4a
Compare
ptrus
reviewed
Dec 16, 2024
|
|
||
| const ( | ||
| artifactContainerRuntime = "rofl-container runtime" | ||
| artifactContainerCompose = "docker-compose.yaml" |
There was a problem hiding this comment.
Last time I tried it (maybe ~year ago), podman-compose (and even podman in general) wasn't really a drop-in replacement to docker-compose in practice, and it was somewhat tedious migrating things to podman. There were a lot of minor incompatibilities.
I hope this has improved, otherwise it might be better to be very clear that podman is used to run the containers. Maybe even go as far to use compose.yaml filename, which seems to be preferred in the latest spec and avoid mentioning docker.
kostko
force-pushed
the
kostko/feature/rofl-tdx-podman
branch
3 times, most recently
from
defa667 to
840afff
Compare
kostko
force-pushed
the
kostko/feature/rofl-tdx-podman
branch
from
840afff to
9908af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.